Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix texture rotation, <3 @gimhael, fix #35 #208

Merged
merged 1 commit into from Jul 8, 2019

Conversation

4 participants
@illwieckz
Copy link
Member

commented Jul 1, 2019

code by @gimhael 馃嵕 馃挴 馃帀

it works and fix #35:

parpax fan

train fan

metro fan

@illwieckz illwieckz added this to To do in Unvanquished via automation Jul 1, 2019

@illwieckz illwieckz added this to To do in Smokin' Guns via automation Jul 1, 2019

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

From up to down: scenes known to previously reproduce the bug in parpax map (Unvanquished), train map (Smokin' Guns), metro map (Tremulous).

@illwieckz illwieckz force-pushed the illwieckz:fixrotate branch from d6e7e8c to 9ed273f Jul 3, 2019

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

I added the second occurrence of the - 0.5 trick to be consistent.

I quoted some of your words to prevent people to drop or leftover this trick in future optimization/revamp.

@illwieckz illwieckz force-pushed the illwieckz:fixrotate branch from 9ed273f to fba13b9 Jul 6, 2019

@illwieckz illwieckz force-pushed the illwieckz:fixrotate branch from ebdac29 to 3a61cc3 Jul 6, 2019

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

does anyone has anything to say more?

@cmf028

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

LGTM, though it may be more optimal to just bake the translation into the texture transform matricies. That way, you wouldn't sacrifice texture coord precision. It is unlikely to be that much of an issue though.

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

I'm not sure to understand how to do it. So code that works that exists is better than code that may be better but does not exist 馃槢.

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

@cmf028 I'm merging it. If you have a better idea feel free to submit a PR but I would prefer seeing progress on some other projects you know better than me. 馃榿

@illwieckz illwieckz force-pushed the illwieckz:fixrotate branch from 3a61cc3 to 5f57ba0 Jul 8, 2019

@illwieckz illwieckz merged commit 5f57ba0 into DaemonEngine:master Jul 8, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Unvanquished automation moved this from To do to Done Jul 8, 2019

Smokin' Guns automation moved this from To do to Done Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.