Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disconnected download #217

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@slipher
Copy link
Member

commented Jul 28, 2019

No description provided.

Remove disconnected download
This feature is pretty useless since no UI support is implemented. Also,
nothing happens when the download completes. So it's just a file
secretly downloading in the background which might eventually finish if
you happen to stay on the main menu long enough.
{
if ( cls.bWWWDlDisconnected )
// tracking potential web redirects leading us to wrong checksum - only works in connected mode
if ( strlen( clc.redirectedList ) + strlen( cls.originalDownloadName ) + 1 >= sizeof( clc.redirectedList ) )

This comment has been minimized.

Copy link
@illwieckz

illwieckz Jul 28, 2019

Member

this makes me discovering there is code to attempt to handle redirects… because of course redirects don't work! 😏

This comment has been minimized.

Copy link
@slipher

slipher Jul 28, 2019

Author Member

There is not really any code to handle redirects. It's just a list of downloaded files.

@slipher slipher merged commit 63936a9 into DaemonEngine:master Jul 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:discondl branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.