Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start throwing exceptions for disconnect #218

Merged
merged 5 commits into from Aug 8, 2019

Conversation

@slipher
Copy link
Member

commented Jul 30, 2019

This avoids weird states where a lot of code is unexpectedly executing after a disconnect.

slipher added some commits Jul 6, 2019

Support use of DropErr in non-error cases
A boolean member is added to DropErr indicating whether there was an
error, or the cgame is being shut down for a non-error reason.
Disconnect by throwing DropErr, when possible
In cases where other stuff needs to be done after calling CL_Disconnect,
catch any DropErr from CL_Disconnect and turn it into a fatal error, to
avoid getting the system into a bad state. CL_Disconnect is supposed to
avoid causing errors, so this "shouldn't happen".

@slipher slipher force-pushed the slipher:initialize6 branch from 257766f to 112a44a Jul 31, 2019

@slipher slipher merged commit 60fc116 into DaemonEngine:master Aug 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@slipher slipher deleted the slipher:initialize6 branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.