Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HTTP download enhancements #222
Refactor the HTTP download code with better handling of libcurl errors.
Reviewers may prefer to look at the combined (as opposed to per-commit) diffs for dl_main.cpp as I moved some stuff around multiple times.
Before merging, we should get everyone running a server with HTTP downloads enabled to add the PAKSERVER file.
illwieckz left a comment •
Oh, I thought you were removing it because of #16 (this would be better to put this string in a config file shipped with the game that to hardcode it in engine).
That's a mistake and I'm guilty. I'll fix that
If I strongly believe it's better to not hardcode this path, this path must work in any way.
Hmm, right, that's very strong. I just tested default apache and nginx default listing behavior and they both hide hidden dot files. I truly agree the behavior must be explicit and obvious, and for example people must be able to download the
Well, it's not like if our engine was named “Daemon”
I also thought about DPKSERVER, which is not bad as it is coherent with the whole DPK strategy. I'm not sure it have to be DPK centric in any way, the engine itself being compatible with legacy PK3 and other project may mimic us to avoid the same kind of issue.
I also thought about something: our game does not fetch game content from website but it may be possible in the future to do it (the way War§ow does with blog posts), in that case it would make sense to rely on the same PAKSERVER mechanism, the PAKSERVER would not be very meaningful, but it's probably not a big issue. What is important is that it's meaningful for paks.
And yes, of course PAKistan has SERVERs.
Instead of the « server » meaning, why not something like directory, registry, library, repository, collection, or something like that?… in fact we really don't care about the server, what is important is what is served, what is available. The directory containing paks is not a server itself, it's a collection or a repository. We don't flag a server (or we would better use the