Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CVAR_LATCH for new cvars #272

Merged
merged 7 commits into from Jan 17, 2020
Merged

Implement CVAR_LATCH for new cvars #272

merged 7 commits into from Jan 17, 2020

Conversation

@slipher
Copy link
Member

slipher commented Jan 13, 2020

To do before merging: Prevent The change will take effect after restart messages from being printed when the cvars are set from command line/configs.

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Jan 15, 2020

thanks for doing this!

@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Jan 15, 2020

I rebased #262 over this and it works correctly on my end. LGTM.

src/common/Cvar.h Outdated Show resolved Hide resolved
@illwieckz

This comment has been minimized.

Copy link
Member

illwieckz commented Jan 16, 2020

good.

@slipher slipher merged commit 3d2acb2 into DaemonEngine:master Jan 17, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@slipher slipher deleted the slipher:latch branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.