Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist image source files like xcf and other formats, fix #1 #6

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@illwieckz
Copy link
Member

commented Jul 30, 2019

fix #1
obsolete #3

I've heard there is many improvements doable in Sloth, by I feel that is up to other pull requests.
#3 is open since more than two years just because those extra features are waiting for.

The real need is to enable Sloth to run on Unvanquished asset repositories, which is not yet true for a couple of them.

Even if we support one day crn detection with some fallback, even if we support format priority one day (like the engine does), even if we implement any other improvement we can dream off, I see really no reason to not simply blacklist xcf files and stuff like that, those are never meant to be used in game or mapping tools or anything like that, so sloth can just ignore them.

@Viech

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Having this configurable like the other options would look cleaner to me, but otherwise (and apart from a wild >) this LGTM.

@illwieckz illwieckz force-pushed the illwieckz:blacklist branch from abf69b2 to 070394f Aug 19, 2019

@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

ok, fixed the lone > (good catch!)

@illwieckz illwieckz merged commit 070394f into DaemonEngine:master Aug 19, 2019

@illwieckz illwieckz deleted the illwieckz:blacklist branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.