Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes #1

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@illwieckz
Copy link
Member

commented Jul 1, 2019

  • rename String to MyString since php7 defines String (@DolceTriade's fix)
  • do not parse master server response EOF as an ipv4
@illwieckz

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Second commit prevents a wrong 0.0.0.0 server to appear on https://unvanquished.net/?page_id=340

Hopefully I've already put my hand on such dark magic while working on qstat, and I know how to use wireshark, so I was able to fix this…

engine.php Outdated Show resolved Hide resolved
engine.php Show resolved Hide resolved
do not parse master server response EOF as an ipv4
and remove the ugly workaround that was used to hide the buffer overflow

@illwieckz illwieckz force-pushed the illwieckz:fix branch from dd4e477 to edbe4ff Jul 1, 2019

@illwieckz illwieckz added the bug label Aug 5, 2019

@illwieckz illwieckz merged commit edbe4ff into DaemonEngine:master Aug 5, 2019

@illwieckz illwieckz referenced this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.