Handle cancelling faction quests correctly. Fix some skills not improving correctly. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to post the quest prize/penalties so that DeadlineExpired isn't sent to the quest that caused the faction loss (otherwise it generates a debug message).
The tougher code changes caused the dodge/block/parry improvement code to be skipped.
skittles1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a player fails a faction loyalty quest, DeadlineExpired is sent to all faction quests including the one that just failed. QuestNode handles this correctly and doesn't try to fail the quest twice, but the correct behavior here is to Post the rewards so that the failing quest is cleaned up (and removed from the player's quest list) before trying to clear all active faction quests for that player.
Fixed dodge/block/parry not improving due to some code being skipped in AdvancementCheck.