Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with jQuery 3 #83

Open
tvsbrent opened this issue Nov 15, 2016 · 2 comments
Open

Not working with jQuery 3 #83

tvsbrent opened this issue Nov 15, 2016 · 2 comments

Comments

@tvsbrent
Copy link

tvsbrent commented Nov 15, 2016

As part of updating our project's dependencies, I updated our version of jQuery from 2.2.4 to 3.1.1. At that point, the tour tips no longer appeared. I haven't untangled the root of the issue, but once I went back to jQuery 2.2.4, the tips worked again.

Based on the fact there is an open PR against the project to change the selection logic to use document.querySelector in place of jQuery, my guess is that it has to do with the selector logic.

@booleanbetrayal
Copy link
Contributor

@tvsbrent - Have you figured out the issue in relation to jQuery 3.1.1 yet?

@localBlackMage
Copy link

@tvsbrent @booleanbetrayal @DaftMonk

The issue stems from jQuery 3.1.1's .fadeIn not appending display: block; to the div.tool-tip container element. Setting tourConfig.animation = false; will get around this issue, but you lose fade in capability.

dylanjha added a commit to crowdcst/angular-tour that referenced this issue Apr 13, 2017
* animation is broken with jQuery's fadeIn()
* DaftMonk#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants