-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement / Print “accessing as <user>” in client #493
Conversation
@kbolashev i have implemented initial version which works fine, but isn't efficient: in cases where we call so we have 2 options, leave it as is, or make required adjustments to skip the redundant http call.
this will require more complicated logic, and i'm not sure the scope of this task covers that. WDYT? |
I think you can change the signature and name of Turn it into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I left a bunch of minor things that need to be changed, but the logic is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on the first feature PR for the client!!! 🥳
notion ticket: https://www.notion.so/dagshub/Print-accessing-as-user-in-client-92af32ddfce2477ba7184722634fb891?pvs=4