[leehyeyun] WEEK 03 solutions #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hozzijeong
approved these changes
Nov 29, 2025
Contributor
hozzijeong
left a comment
hozzijeong
left a comment
There was a problem hiding this comment.
이번 주도 고생하셨습니다! 풀이가 너무 깔끔하네요!
Comment on lines
+63
to
+64
| let binaryString = n.toString(2); | ||
| let value = binaryString.split("").filter(x => x === "1").length; |
Contributor
There was a problem hiding this comment.
바로 이진수로 변환해서 1만 추려내는 방식이군요!
저도 이와 비슷하게 풀었습니다!!
혹시 let을 사용한 이유가 있을까요?
Contributor
Author
There was a problem hiding this comment.
안녕하세요, 좋은 피드백 감사합니다 ㅎㅎ
사실 저 부분은 깊게 생각하지 않고 let을 사용했는데,
값이 재할당되지 않으니 const가 더 적절하겠네요 . ㅎㅎ
다음부터는 변수 성격에 맞게 선언할 수 있도록 개선하겠습니다. 감사합니다 :)
| */ | ||
| var isPalindrome = function(s) { | ||
|
|
||
| let cleanString = s.toLowerCase().replace(/[^a-z0-9]/g, ''); |
Contributor
There was a problem hiding this comment.
확실히 정규식으로 제거해 버리는게 깔끔하긴 하네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!