Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable variable auth-source-pass-port-separator #87

Merged
merged 2 commits into from Apr 8, 2019

Conversation

@iquiw
Copy link
Contributor

iquiw commented Apr 7, 2019

Fixes #86

New customizable variable, auth-source-pass-port-separator, is added to
specify separator between host and port, default to colon (":").
Copy link
Owner

DamienCassou left a comment

Awesome work, thank you. Can you please do the little docstring fix I suggest if you are ok with it?

@@ -47,6 +47,10 @@
"Path to the password-store folder."
:type 'directory)

(defcustom auth-source-pass-port-separator ":"
"Separator string between host and port in password filename."

This comment has been minimized.

Copy link
@DamienCassou

DamienCassou Apr 8, 2019

Owner

I think "entry" is more appropriate than password here.

This comment has been minimized.

Copy link
@iquiw

iquiw Apr 8, 2019

Author Contributor

Thanks for review!
I updated the docstring.

@DamienCassou

This comment has been minimized.

Copy link
Owner

DamienCassou commented Apr 8, 2019

Have you signed the FSF copyright assignment form? Because auth-password-store is included in Emacs core, this is required.

@iquiw iquiw force-pushed the iquiw:custom-port-separator branch from 54b42b6 to 42451c2 Apr 8, 2019
@iquiw

This comment has been minimized.

Copy link
Contributor Author

iquiw commented Apr 8, 2019

Have you signed the FSF copyright assignment form?

Yes. I have done my paper work when contributing to abo-abo/swiper#1745 (comment)

@DamienCassou DamienCassou merged commit 96fd4f0 into DamienCassou:master Apr 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DamienCassou

This comment has been minimized.

Copy link
Owner

DamienCassou commented Apr 8, 2019

Awesome, thank you very much.

@iquiw iquiw deleted the iquiw:custom-port-separator branch Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.