From ca367b4f10f67eb54ca1ff05c0ea61145d07be64 Mon Sep 17 00:00:00 2001 From: Damien Harper Date: Thu, 9 Jan 2020 09:41:21 +0100 Subject: [PATCH] Fixed pager when viewing a entity history with lots of entries (#162) (#163) --- .../views/Audit/entity_history.html.twig | 2 +- .../views/Audit/helpers/pager.html.twig | 44 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/DoctrineAuditBundle/Resources/views/Audit/entity_history.html.twig b/src/DoctrineAuditBundle/Resources/views/Audit/entity_history.html.twig index 3ad0962d..b9514e7c 100644 --- a/src/DoctrineAuditBundle/Resources/views/Audit/entity_history.html.twig +++ b/src/DoctrineAuditBundle/Resources/views/Audit/entity_history.html.twig @@ -26,7 +26,7 @@ {% endfor %} - {{ pager.render(entity, paginator) }} + {{ pager.render(entity, id, paginator) }} {% endblock dh_doctrine_audit_content %} diff --git a/src/DoctrineAuditBundle/Resources/views/Audit/helpers/pager.html.twig b/src/DoctrineAuditBundle/Resources/views/Audit/helpers/pager.html.twig index bc3fc4b5..bb675f2d 100644 --- a/src/DoctrineAuditBundle/Resources/views/Audit/helpers/pager.html.twig +++ b/src/DoctrineAuditBundle/Resources/views/Audit/helpers/pager.html.twig @@ -1,4 +1,4 @@ -{% macro render(entity, paginator, proximity = 3, displayedPages = 10) %} +{% macro render(entity, id = null, paginator, proximity = 3, displayedPages = 10) %} {% if paginator.haveToPaginate %} {% set start = paginator.currentPage - proximity %} {% set end = paginator.currentPage + proximity %} @@ -13,72 +13,72 @@ {% endif %} {% endmacro render %} -{% macro first(entity, paginator) %} +{% macro first(entity, id, paginator) %} {% if paginator.hasPreviousPage %} -
  • {% trans %}audit.pager.first{% endtrans %}
  • +
  • {% trans %}audit.pager.first{% endtrans %}
  • {% else %}
  • {% trans %}audit.pager.first{% endtrans %}
  • {% endif %} {% endmacro first %} -{% macro previous(entity, paginator) %} +{% macro previous(entity, id, paginator) %} {% if paginator.hasPreviousPage %} -
  • {% trans %}audit.pager.previous{% endtrans %}
  • +
  • {% trans %}audit.pager.previous{% endtrans %}
  • {% else %}
  • {% trans %}audit.pager.previous{% endtrans %}
  • {% endif %} {% endmacro previous %} -{% macro dotsIfStartIsOver3(entity, paginator, start) %} +{% macro dotsIfStartIsOver3(entity, id, paginator, start) %} {% if start > 1 %}
  • {% endif %} {% endmacro dotsIfStartIsOver3 %} -{% macro pages(entity, paginator, start, end) %} +{% macro pages(entity, id, paginator, start, end) %} {% for i in start..end %} - {{ _self.page(entity, paginator, i) }} + {{ _self.page(entity, id, paginator, i) }} {% endfor %} {% endmacro pages %} -{% macro dotsIfEndIsUnder3ToLast(entity, paginator, end) %} +{% macro dotsIfEndIsUnder3ToLast(entity, id, paginator, end) %} {% if end < paginator.numPages %}
  • {% endif %} {% endmacro dotsIfEndIsUnder3ToLast %} -{% macro next(entity, paginator) %} +{% macro next(entity, id, paginator) %} {% if paginator.hasNextPage %} -
  • +
  • {% else %}
  • {% trans %}audit.pager.next{% endtrans %}
  • {% endif %} {% endmacro next %} -{% macro last(entity, paginator) %} +{% macro last(entity, id, paginator) %} {% if paginator.hasNextPage %} -
  • {% trans %}audit.pager.last{% endtrans %}
  • +
  • {% trans %}audit.pager.last{% endtrans %}
  • {% else %}
  • {% trans %}audit.pager.last{% endtrans %}
  • {% endif %} {% endmacro last %} -{% macro page(entity, paginator, page) %} +{% macro page(entity, id, paginator, page) %} {% if page == paginator.currentPage %}
  • {{ page }} {% trans %}audit.pager.current{% endtrans %}
  • {% else %} -
  • {{ page }}
  • +
  • {{ page }}
  • {% endif %} {% endmacro page %}