New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider flake8 as linting library #9

Closed
schlamar opened this Issue Aug 8, 2013 · 8 comments

Comments

Projects
None yet
4 participants
@schlamar

schlamar commented Aug 8, 2013

It is a nice wrapper around pyflakes and pep8: https://pypi.python.org/pypi/flake8

@schlamar

This comment has been minimized.

Show comment
Hide comment
@schlamar

schlamar commented Aug 8, 2013

See https://github.com/schlamar/flake8-immediate/blob/master/flake8_immediate.py how to get the output from flake8 within Python.

@DamnWidget

This comment has been minimized.

Show comment
Hide comment
@DamnWidget

DamnWidget Aug 8, 2013

Owner

The linter part of the plugin needs to be eventually fully refactored because now it's really a port from SublimeLinter with some optimization improvements.

I will take a look at flake8 then.

Owner

DamnWidget commented Aug 8, 2013

The linter part of the plugin needs to be eventually fully refactored because now it's really a port from SublimeLinter with some optimization improvements.

I will take a look at flake8 then.

@dan-blanchard

This comment has been minimized.

Show comment
Hide comment
@dan-blanchard

dan-blanchard Aug 15, 2013

I would love to see this take over for the seemingly deceased Pylinter project that used pylint instead of pyflakes. pylint is just much much more thorough. I've been considering forking Pylinter (because they won't merge the pull request that makes it work with ST3), but pylint integration for anaconda would mean I don't have to do that. :)

dan-blanchard commented Aug 15, 2013

I would love to see this take over for the seemingly deceased Pylinter project that used pylint instead of pyflakes. pylint is just much much more thorough. I've been considering forking Pylinter (because they won't merge the pull request that makes it work with ST3), but pylint integration for anaconda would mean I don't have to do that. :)

@DamnWidget

This comment has been minimized.

Show comment
Hide comment
@DamnWidget

DamnWidget Aug 15, 2013

Owner

Hi @dan-blanchard

If you don't mind to open a new issue with this topic about pylint we can discuss it with the rest of the community.

Regards.

Owner

DamnWidget commented Aug 15, 2013

Hi @dan-blanchard

If you don't mind to open a new issue with this topic about pylint we can discuss it with the rest of the community.

Regards.

@ekarlso

This comment has been minimized.

Show comment
Hide comment
@ekarlso

ekarlso Aug 19, 2013

Any news on this? I am really stuck with linting stuffs.

ekarlso commented Aug 19, 2013

Any news on this? I am really stuck with linting stuffs.

@DamnWidget

This comment has been minimized.

Show comment
Hide comment
@DamnWidget

DamnWidget Aug 19, 2013

Owner

Hi @ekarlso

I don't understand what you mean, why are you stuck with linting stuff? Anaconda already has full support for PyFlakes and PEP8, so use or not use flakes8 is a convenience matters.

I didn't had the time to check that library so I didn't analyze what the impact of switch can be or what the problems are or how trustable is use a layer from a third in terms of actualizations.

I have to consider how easy is to turn on and off each linter using flakes8. There is an interesting question about Pylint as well.

Owner

DamnWidget commented Aug 19, 2013

Hi @ekarlso

I don't understand what you mean, why are you stuck with linting stuff? Anaconda already has full support for PyFlakes and PEP8, so use or not use flakes8 is a convenience matters.

I didn't had the time to check that library so I didn't analyze what the impact of switch can be or what the problems are or how trustable is use a layer from a third in terms of actualizations.

I have to consider how easy is to turn on and off each linter using flakes8. There is an interesting question about Pylint as well.

@ekarlso

This comment has been minimized.

Show comment
Hide comment
@ekarlso

ekarlso Aug 19, 2013

Nevermind that :)

ekarlso commented Aug 19, 2013

Nevermind that :)

@DamnWidget

This comment has been minimized.

Show comment
Hide comment
@DamnWidget

DamnWidget Sep 2, 2013

Owner

I don't see the need to add a new wrapping layer in the top of those libraries, I'm not going to implement this but I will consider any pull request that adds it (but I really don't think we need this at all).

Owner

DamnWidget commented Sep 2, 2013

I don't see the need to add a new wrapping layer in the top of those libraries, I'm not going to implement this but I will consider any pull request that adds it (but I really don't think we need this at all).

@DamnWidget DamnWidget closed this Sep 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment