New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add series of images to the sidebar. #190

Merged
merged 2 commits into from May 20, 2015

Conversation

Projects
None yet
3 participants
@dmark
Copy link
Contributor

dmark commented May 20, 2015

Add a series of images to the sidebar.

This is my first real pull request, so helpful tips and "take a hike amateur" are all appreciated. Let me know what I can do better. I cloned the source repo and pulled it down to my machine, made a branch, made my changes on the branch, pushed the branch back to my cloned repo and then created the pull request. Wasn't sure if I should have merged the branch with my master first.

Adds a series of images specified in SIDEBAR_IMAGES to the sidebar. The code is mostly a cut and paste of links.html and aboutme.html. I originally set this up to stick Amazon Web Services certification PNGs in my sidebar. Looks like:

screenshot_2015-05-20_15-59-33

@DandyDev

This comment has been minimized.

Copy link
Owner

DandyDev commented May 20, 2015

Thanks for the PR! I added a couple of tips to the code. Maybe you could update your PR with those?

@dmark

This comment has been minimized.

Copy link
Contributor Author

dmark commented May 20, 2015

Will do. Thanks for the feedback. Do we close this one and I create a new one once my changes are made?

@DandyDev

This comment has been minimized.

Copy link
Owner

DandyDev commented May 20, 2015

Nope, as long as you add the changes to the branch you already had, they will automatically be included in this current PR.
BTW, your PR is much better than a lot of stuff from open source "veterans" I come across, so you're doing great :)

@dmark

This comment has been minimized.

Copy link
Contributor Author

dmark commented May 20, 2015

Thanks again. Made your suggested changes and pushed it to the new branch. I think I did that right.

DandyDev added a commit that referenced this pull request May 20, 2015

Merge pull request #190 from dmark/sidebar-images
Add series of images to the sidebar.

@DandyDev DandyDev merged commit 6337c52 into DandyDev:master May 20, 2015

@DandyDev

This comment has been minimized.

Copy link
Owner

DandyDev commented May 20, 2015

Done :) You can now throw away your feature branch in your own fork.

@cranmer

This comment has been minimized.

Copy link

cranmer commented May 20, 2015

interesting to watch open source in progress

@dmark dmark deleted the dmark:sidebar-images branch May 20, 2015

@dmark

This comment has been minimized.

Copy link
Contributor Author

dmark commented May 20, 2015

Sweet. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment