Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMineral veins generating less frequently than they should, espeically in zero-size cities #12
Comments
DangerNoodle
added
the
bug
label
Jan 29, 2018
This comment has been minimized.
This comment has been minimized.
|
An unexpected bad crash during random character generation is preventing tests with 7081, but I could see what can be done with the older ones. |
This comment has been minimized.
This comment has been minimized.
|
Part of it's probably also CleverRaven/Cataclysm-DDA#22827 |
This comment has been minimized.
This comment has been minimized.
|
A fix for overmap specials was merged recently. CleverRaven/Cataclysm-DDA#24860 |
This comment has been minimized.
This comment has been minimized.
|
Any tests so far with mining mod? Might give it a look if dangernoodle isn't on by tomorrow. |
This comment has been minimized.
This comment has been minimized.
chaosvolt
closed this
Aug 17, 2018
This comment has been minimized.
This comment has been minimized.
|
My apologies for having been absent for so long. You are right, it does appear to be resolved. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment

DangerNoodle commentedJan 29, 2018
This came about after discussion over email with @chaosvolt, who has been playtesting this mod as of late, during my recent period of inactivity. Part of their current enabling as a collaborator for the time being.
Mineral veins have severe difficulty generating at present, despite all tested efforts to enable their generation. Generally a given overmap does not even contain the minimum demanded by the overmap specials. This problem is exacerbated when cities are set to 0, along with many vanilla areas that should be showing up but do not.
While their appearances are less limited when cities are enabled, it has been determined for the time being that overriding occurrences of existing specials, the method @pisskop discovered, is presently not worth the potential mod interactions and incompatibilities. As such Chaosvolt advocated their removal and a reduction in the minimums. As I have been rather busy with offline concerns as of late, I have enabled them as a collaborator, and will invite @BorkBorkGoesTheCode as well.
I do however request that major changes be made in the form of a pull request first rather than a direct commit, even if self-merged in my absence, for ease of tracking changes.