Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mineral veins generating less frequently than they should, espeically in zero-size cities #12

Closed
DangerNoodle opened this issue Jan 29, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@DangerNoodle
Copy link
Owner

commented Jan 29, 2018

This came about after discussion over email with @chaosvolt, who has been playtesting this mod as of late, during my recent period of inactivity. Part of their current enabling as a collaborator for the time being.

Mineral veins have severe difficulty generating at present, despite all tested efforts to enable their generation. Generally a given overmap does not even contain the minimum demanded by the overmap specials. This problem is exacerbated when cities are set to 0, along with many vanilla areas that should be showing up but do not.

While their appearances are less limited when cities are enabled, it has been determined for the time being that overriding occurrences of existing specials, the method @pisskop discovered, is presently not worth the potential mod interactions and incompatibilities. As such Chaosvolt advocated their removal and a reduction in the minimums. As I have been rather busy with offline concerns as of late, I have enabled them as a collaborator, and will invite @BorkBorkGoesTheCode as well.

I do however request that major changes be made in the form of a pull request first rather than a direct commit, even if self-merged in my absence, for ease of tracking changes.

@DangerNoodle DangerNoodle added the bug label Jan 29, 2018

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2018

An unexpected bad crash during random character generation is preventing tests with 7081, but I could see what can be done with the older ones.

@chaosvolt

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2018

Part of it's probably also CleverRaven/Cataclysm-DDA#22827

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2018

A fix for overmap specials was merged recently. CleverRaven/Cataclysm-DDA#24860

@chaosvolt

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2018

Any tests so far with mining mod? Might give it a look if dangernoodle isn't on by tomorrow.

@chaosvolt

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2018

yeehaw

Yep, this looks like a good improvement. Might be acceptable to close, I hope.

@chaosvolt chaosvolt closed this Aug 17, 2018

@DangerNoodle

This comment has been minimized.

Copy link
Owner Author

commented Aug 17, 2018

My apologies for having been absent for so long.

You are right, it does appear to be resolved. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.