New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternion constructor should construct identity quaternion #31

Closed
haikarainen opened this Issue Jul 27, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@haikarainen

haikarainen commented Jul 27, 2017

As the title states. Right now it constructs an invalid quaternion, which would result in an assert if you were to use a default-constructed quaternion in the transform for a collision shape.

// Constructor of the class
Quaternion::Quaternion() : x(0.0), y(0.0), z(0.0), w(1.0) {

}

Btw, thank you for a splendid library! Very clean API, a breeze to work with 💯

@DanielChappuis

This comment has been minimized.

Owner

DanielChappuis commented Jul 27, 2017

Yes this is a good idea. I will make this change for the next release (version 0.7.0) of the library.

@DanielChappuis DanielChappuis self-assigned this Jul 27, 2017

@DanielChappuis DanielChappuis added this to the Version 0.7.0 milestone Jul 27, 2017

@ZelimDamian

This comment has been minimized.

ZelimDamian commented Mar 11, 2018

Is this issue solved simply by changing the constructor initialiser? I ran tests after making the changes - all succeeded. All testbeds work just fine.
If there are usages which could be broken, I am willing to look into it, but could really use some directions.
Otherwise, I will PR?

@DanielChappuis

This comment has been minimized.

Owner

DanielChappuis commented Mar 12, 2018

This issue is already solved in the "develop" branch. I will merge this branch into "master" soon in order to release the next version (0.7.0) of the library. I will close this issue only when it has been part of the "master" branch.

@DanielChappuis

This comment has been minimized.

Owner

DanielChappuis commented May 1, 2018

This is now available in the version v0.7.0 of ReactPhysics3D that has just been released.
Thanks a lot for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment