Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Parser breaks indentation of existing files" #60

Merged
merged 7 commits into from Aug 10, 2019

Conversation

@munen
Copy link
Contributor

commented Aug 4, 2019

Related issue: #56

Status: The indentation bug is fixed.

Notes:

  • The bug has been fixed in a test-driven manner.
  • I have marked one location in the existing code that could probably be improved (There's a FIXME statement with information). However, I do not want to tackle that one before we either have more tests around the expected functionality or we have a small chat on how you wanted that part of the code to behave. In any case, I think it's 'cosmetic' only at this point as the code is working as far as I can see (in automated tests and manual tests of files with 10k LOC).

Thank you for the good code structure. It's pretty easy to get to know various parts and make changes to them! 馃檹

munen added some commits Aug 4, 2019

test: Write test showing that parser breaks indentation
      This is a first step to resolve #56
fix: parser doesn't change indentation for basic lists
     However, if there's also a planning item in the description, the
     bug still persists.

@munen munen changed the title WIP Fix "Parser breaks indentation of existing files" Fix "Parser breaks indentation of existing files" Aug 4, 2019

@DanielDe DanielDe merged commit 255dc5c into DanielDe:master Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.