Fix fromJust crash #116

Merged
merged 2 commits into from Apr 10, 2013

Conversation

Projects
None yet
2 participants
Contributor

nh2 commented Apr 3, 2013

For it is evil and causes grievance ;)

Contributor

nh2 commented Apr 3, 2013

Note: Don't crash on empty cabal file really only removes the crash, but this isn't enough yet.

When I have an empty cabal file, I get

Tools/Foo/Main.hs:1:1:Could not find module `Prelude'It is a member of the hidden package `base'.Perhaps you need to add `base' to the build-depends in your .cabal file.It is a member of the hidden package `haskell98-2.0.0.2'.Perhaps you need to add `haskell98' to the build-depends in your .cabal file.It is a member of the hidden package `haskell2010-1.1.1.0'.Perhaps you need to add `haskell2010' to the build-depends in your .cabal file.Use -v to see a list of the files searched for.

Deleting the .cabal fixes it, but how can we make it work anyway (or at least give a good error message)?

In the comment, you wrote Causes error, catched in the upper function (I forgot to delete that). In which upper function did you mean?

@kazu-yamamoto kazu-yamamoto added a commit that referenced this pull request Apr 10, 2013

@kazu-yamamoto kazu-yamamoto Merge pull request #116 from nh2/fix-fromJust
Fix fromJust crash
b574022

@kazu-yamamoto kazu-yamamoto merged commit b574022 into DanielG:master Apr 10, 2013

1 check passed

default The Travis build passed
Details
Collaborator

kazu-yamamoto commented Apr 10, 2013

Thank you for your contributions. I have mereged your patch.

Let's move to #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment