Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confetti size system #7

Closed
DanielMartinus opened this issue May 28, 2017 · 0 comments

Comments

@DanielMartinus
Copy link
Owner

commented May 28, 2017

Problem

  • The current system to adjust and add sizes to confetti library is not ideal. It only lets you choose between three sizes which are relatively large on small mdpi screens because they are defined in pixels and were tested on large phone screens.
  • konfetti.models.Size class has a confusing name since Size is also already used in the Android SDK

Solution

Currently thinking of rewriting this part of the system to allow the users to add any particle size to the system instead of having to rely on Size.SMALL, Size.MEDIUM and Size.LARGE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.