Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 1 #1

Closed
theaspect opened this Issue Apr 11, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@theaspect
Copy link

theaspect commented Apr 11, 2019

  1. main.kt ArrayList() -> listOf
  2. разбей классы по пакетам service, domain
  3. user = userService.findUserByLogin(login, users) старайся не разбивать декларацию переменной и присвоение значения
  4. старайся передавать минимальный контекст fun authentication(cmd: Cmd замени на login, pass
  5. внутри энама можно хранить экзит коды в виде целых числе
  6. Вынеси sha256 в отдельный файл в функцию и избавься от private val businessLogic: BusinessLogic = BusinessLogic() в UserService

@Danil42Russia Danil42Russia pinned this issue Apr 12, 2019

@Danil42Russia Danil42Russia unpinned this issue Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.