feature(dao-svg): add svg #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
由于这个问题，本来周一要解决，而且重要性比较高，请 @ZhuJingSi @jamiefang 尽快review并推进，如果需要其他同事帮助，请尽快involve |
Ye-Ting
reviewed
Jun 27, 2017
examples/routers/svg.vue
Outdated
| console.log(this.svgs); | ||
| }, | ||
| }; | ||
| </script> |
There was a problem hiding this comment.
注意文件格式，建议将编辑器添加editorconfig
|
update |
|
svg 需要文档么？以及设计师怎么添加图标需要在某处说明吧 |
|
需要！ 文档 会 提 另一个 pr 的 |
Closed
|
和老的 dao-style 对比少了一个图标？ |
|
svg-sprite-loader 升级没问题？DCE-UI 里的不能升级，不然有些图标就解析不了，不知什么原因 @vivian-xu @jamiefang |
|
@ZhuJingSi 我之前在 DCE-UI 里试过，目前是没问题 |
|
@vivian-xu 好像少了 color-icon_websphere 等几个图标，可以和以前 demo 站上的图标做对比 |
|
@cinderyx 不是所有图标都解析不了，是一部分 |
|
好 我看下 |
|
这个图标可能我之前并没有commit过。
… On 28 Jun 2017, at 11:18 AM, CIN ***@***.***> wrote:
@vivian-xu <https://github.com/vivian-xu> 好像少了 color-icon_websphere 这个图标
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#192 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGrTtYpEVbY1EswfC934U0NepwJvJ_epks5sIcYMgaJpZM4OFQjy>.
|
|
update |
|
@ZhuJingSi Vivian的更新是否可以满足你的要求，如果可以的话，请尽快的推进这个PR的发展。 |
cinderyx
reviewed
Jun 30, 2017
src/components/dao-svg/svg.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| // import all svg | |||
| const requireAll = requireContext => requireContext.keys().map(requireContext); | |||
| const requireAll = requireContext => requireContext.keys().forEach(requireContext); | |||
There was a problem hiding this comment.
我不需要它返回一个新的数组给我啊。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
步骤一
请您按照规范确认这个PR的类型：
步骤二
完成以下内容的填写，您就可以顺利提交 Pull Request：
1. 填写Pull Reqeust主要针对的类型于下一行，选项有：bug/feature(特性)/enhancement(增强)/docs(文档)
feature
2. Pull Request的简要介绍（请填于下一行）
3. Pull Request针对问题的重现方式（没有请在下一行填“无”）
无
4. Pull Request可能涉及到的组件范围（没有请在下一行填“无”）
无