$-sign in Markdown causes strange issue #4

Closed
jooize opened this Issue Nov 6, 2015 · 5 comments

Comments

Projects
None yet
3 participants

jooize commented Nov 6, 2015

Markdown:

- [XenForo](https://xenforo.com/): $140+ with one year of upgrades, and $40 per each additional year.

Result:

Removing the first ‘$’ makes it render correctly.

This comment has been minimized.

Show comment Hide comment
@brossi

brossi Nov 6, 2015

Contributor

That is firing incorrectly because of the KaTeX parsing. I've got a working build that corrects it, though it requires that inline KaTeX be indicated by wrapping the equation text with $[ and ]$ instead of $ and $. I believe that it's a worthwhile trade-off, but if anyone has a contrary opinion, please let me know.

Contributor

brossi commented Nov 6, 2015

That is firing incorrectly because of the KaTeX parsing. I've got a working build that corrects it, though it requires that inline KaTeX be indicated by wrapping the equation text with $[ and ]$ instead of $ and $. I believe that it's a worthwhile trade-off, but if anyone has a contrary opinion, please let me know.

This comment has been minimized.

Show comment Hide comment
@brossi

brossi Nov 6, 2015

Contributor

Actually, upon further consideration, I will use $$ as the starting and ending indicator for inline equations and $$$ for block displayed equations. The block delimiter has precedence because we use a triple backtick to denote the start and end of a block displayed code section.

Thank you for identifying this and I'll get a patch deployed shortly to address this.

Contributor

brossi commented Nov 6, 2015

Actually, upon further consideration, I will use $$ as the starting and ending indicator for inline equations and $$$ for block displayed equations. The block delimiter has precedence because we use a triple backtick to denote the start and end of a block displayed code section.

Thank you for identifying this and I'll get a patch deployed shortly to address this.

@brossi brossi closed this Nov 6, 2015

This comment has been minimized.

Show comment Hide comment
@CoinGame

CoinGame Nov 6, 2015

This fix should be live on the site now. Let us know if there's any other issues.

CoinGame commented Nov 6, 2015

This fix should be live on the site now. Let us know if there's any other issues.

This comment has been minimized.

Show comment Hide comment
@brossi

brossi Nov 6, 2015

Contributor

Deployed as part of 1.2.1

Contributor

brossi commented Nov 6, 2015

Deployed as part of 1.2.1

This comment has been minimized.

Show comment Hide comment
@jooize

jooize Nov 6, 2015

Great, confirmed working! I will.

jooize commented Nov 6, 2015

Great, confirmed working! I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment