From 6171cefafd99458e6071ea8f2dd644520f3cd002 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Thu, 5 Sep 2024 20:26:16 +0200 Subject: [PATCH 1/3] handle warnings in build --- .github/workflows/dotnet-integration.yml | 4 ++-- .github/workflows/dotnet.yml | 4 ++-- .../Models/DbStringPoco.cs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/dotnet-integration.yml b/.github/workflows/dotnet-integration.yml index 5bd5a8f..0bd61e6 100644 --- a/.github/workflows/dotnet-integration.yml +++ b/.github/workflows/dotnet-integration.yml @@ -13,12 +13,12 @@ jobs: runs-on: ubuntu-20.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 # depth is needed for nbgv - name: Setup .NET - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: | 6.0.x diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index a45009a..e103ec2 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -13,12 +13,12 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 # depth is needed for nbgv - name: Setup .NET - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: | 6.0.x diff --git a/test/Dapper.AOT.Test.Integration.Executables/Models/DbStringPoco.cs b/test/Dapper.AOT.Test.Integration.Executables/Models/DbStringPoco.cs index ed41851..8c846a9 100644 --- a/test/Dapper.AOT.Test.Integration.Executables/Models/DbStringPoco.cs +++ b/test/Dapper.AOT.Test.Integration.Executables/Models/DbStringPoco.cs @@ -5,5 +5,5 @@ public class DbStringPoco public const string TableName = "dbStringPoco"; public int Id { get; set; } - public string Name { get; set; } + public string? Name { get; set; } } \ No newline at end of file From 0190af22e67498b03a2f45215814621242fbf5a5 Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Thu, 5 Sep 2024 20:42:14 +0200 Subject: [PATCH 2/3] another warning --- test/Dapper.AOT.Test.Integration/DbStringTests.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/Dapper.AOT.Test.Integration/DbStringTests.cs b/test/Dapper.AOT.Test.Integration/DbStringTests.cs index 9822803..d0cc359 100644 --- a/test/Dapper.AOT.Test.Integration/DbStringTests.cs +++ b/test/Dapper.AOT.Test.Integration/DbStringTests.cs @@ -37,7 +37,8 @@ public void DbString_BasicUsage_InterceptsAndReturnsExpectedData() { var result = ExecuteInterceptedUserCode(DbConnection); + Assert.NotNull(result); Assert.True(result.Id.Equals(1)); - Assert.True(result.Name.Equals("my-dbString", StringComparison.InvariantCultureIgnoreCase)); + Assert.Equal("my-dbString", result.Name); } } \ No newline at end of file From aa244d8054b399a0dea23bf4ecb68a516a7d011b Mon Sep 17 00:00:00 2001 From: Dmitrii Korolev Date: Thu, 5 Sep 2024 20:51:10 +0200 Subject: [PATCH 3/3] and last one from build --- .github/workflows/dotnet-integration.yml | 3 +-- .github/workflows/dotnet.yml | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/dotnet-integration.yml b/.github/workflows/dotnet-integration.yml index 0bd61e6..ddef954 100644 --- a/.github/workflows/dotnet-integration.yml +++ b/.github/workflows/dotnet-integration.yml @@ -22,8 +22,7 @@ jobs: with: dotnet-version: | 6.0.x - 8.0.x - include-prerelease: true + 8.0.x - name: Build run: dotnet build Dapper.AOT.sln -c Debug diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index e103ec2..4991b89 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -23,7 +23,6 @@ jobs: dotnet-version: | 6.0.x 8.0.x - include-prerelease: true - uses: dotnet/nbgv@master with: