Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid 681 #30

Open
ligi opened this issue Oct 10, 2018 · 6 comments
Open

Invalid 681 #30

ligi opened this issue Oct 10, 2018 · 6 comments

Comments

@ligi
Copy link

ligi commented Oct 10, 2018

Just wanted to try the DAI integration after your announcement on reddit - but the QR-Code is extremely wrong. Does not encode at all that DAI is requested. Also it is completely invalid 681:

selection_244

@mesqueeb
Copy link
Contributor

Thanks for the report I will check the issue.

@mesqueeb
Copy link
Contributor

mesqueeb commented Oct 11, 2018

Dappos DAI scanning with amount works on:

  • trust wallet
  • imToken
  • Enjin Wallet

Wallets with no DAI support:

  • Jaxx
  • Lykke
  • Wei
  • Blockchain
  • tokenPocket
  • Ginco
  • BRD wallet

Wallets who don't allow amount scanning at all:

  • Cipher
  • Coinbase Wallet (former Toshi)
  • Ginco
  • Status

@ligi
Copy link
Author

ligi commented Oct 11, 2018

How can this work? This QR code does not encode that this is a DAI transaction ..

@mesqueeb
Copy link
Contributor

In the three wallets I mention above you need to select DAI in order to send it. Then they all have the same scan functionality as when you'd send ETH. And in all three wallets scanning the Dappos QR code fills in the DAI amount normally.

@ligi
Copy link
Author

ligi commented Oct 11, 2018

dam - this is horrible UX and wrong on so many levels ..

@mesqueeb
Copy link
Contributor

mesqueeb commented Oct 11, 2018

Ah well... We have to focus to make Dappos work with the wallets that support DAI so not much we can do about it. If those wallets start using your EIP then of course we'll also start using that instead. But until then, we need to make sure our app actually works on those wallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants