New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting the party leaders name and other info from a diff map server #5088

Open
TeoTwawki opened this Issue Jul 15, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@TeoTwawki
Copy link
Member

TeoTwawki commented Jul 15, 2018

I have:

  • searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
  • checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) :
n/a

Source Branch (master/stable) :
master

Additional Information (Steps to reproduce/Expected behavior) :
I messed up in #5028 by forgetting I can't get entities across map servers. I knew gotoPlayer worked cross map server so swapped it into where setPos was thinking it was an easy/quick fix.. I knew the function I was using took the name as input and did entity:getName() but if the leader is in a diff map server we have no pointer to get the name from. or get their isInMogHouse() result. My thoughts are: I either need the name of a party leader stored someplace where we don't at all do that yet so I can use sql query to get info on that character OR I need the message server to tell the appropriate map server to do this crap. neither is appealing to me, suggestions welcome.

(yes I know spoilers testing blah blah, I still tested that better than half our contributor pull requests do - I at least didn't break anything else while not really fixing the problem,)

@TeoTwawki TeoTwawki changed the title getting the party leaders name from a diff map server getting the party leaders name and other info from a diff map server Jul 15, 2018

TeoTwawki referenced this issue Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment