Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enmity 2.0 #5614

Merged
merged 11 commits into from Jan 24, 2019

Conversation

@nfaletra
Copy link
Member

nfaletra commented Jan 17, 2019

Used a combination of these enmity tables and forum posts from SE:

Testing Done

  • Tested pretty thoroughly with 2 characters using a good spread of abilities, weaponskills, and spells.
  • Tested CE decay (taking damage from mob) while performing actions (heals, etc) on the target with hate.
  • Did a lot of combinations of attacking while curing and debuffing, not attacking while curing and debuffing, etc.
  • I tested a "PL" healing a low level player as well

In all testing cases, mob's hate behaved as I would have expected. It didn't appear to bounce around while actions against the mob or on other player were controlled. As soon I started spamming things and going wild, hate would move away from my "tank" or bounce around a lot.

Copy link

deviltti left a comment

this one

src/map/enmity_container.cpp Outdated Show resolved Hide resolved
src/map/enmity_container.cpp Outdated Show resolved Hide resolved
@takhlaq takhlaq merged commit 2924080 into DarkstarProject:master Jan 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nfaletra nfaletra deleted the nfaletra:enmity branch Jan 24, 2019
@personaone

This comment has been minimized.

Copy link

personaone commented Jan 27, 2019

hey, how accurate is this? It takes a haste and a cure iii to move hate to my whm with a ninja tanking, dealing non stop damage (about 6% damage by the tank itself) and provoking every 30 seconds. I can't remember hate jumping off a ninja so quickly on retail :/

Same thing happens when tanking as a PLD, flash, provoke, few hits on the mob, flash, reprisal, provoke -> single cure iii from WHM - pulls hate xD

@csundman

This comment has been minimized.

Copy link

csundman commented Jan 27, 2019

We've been playing with this enmity update on our server for a couple days now and everything seems pretty weird now. It just seems like the last person to do anything, be it cast regen... or use "meditate" just pulls hate.

@TeoTwawki

This comment has been minimized.

Copy link
Member

TeoTwawki commented Jan 28, 2019

you guys are saying the same things I saw people saying before this change. for like 3 years straight.

@csundman

This comment has been minimized.

Copy link

csundman commented Jan 28, 2019

Well, I can't say I know much about what people have said previously. From my perspective aggro has been relatively predictable until I updated about 3 days ago. Just thought I'd share the experience in case others had the same. Maybe somebody will find something. /shrug

@davismj

This comment has been minimized.

Copy link
Contributor

davismj commented on sql/abilities.sql in cbf7b1f Feb 3, 2019

@nfaletra y u do dis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.