Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Correction of H2H Weapon DMG Values #5830

Merged
merged 2 commits into from Apr 14, 2019

Conversation

@neuromancerxi
Copy link
Contributor

commented Apr 8, 2019

While reviewing the DMG values of some ilvl119 h2h weapons, I came across a few inconsistencies in h2h damage values:

  1. All non-ilvl119 h2h weapons were 3 base damage higher than they should be
  2. Most/All ilvl119 h2h weapons had incorrect values

After a bit of sleuthing and assistance from Zynjec and Apocalypse in Discord, we pieced together that:

  1. All non ilvl119 h2h weapons had a higher base value potentially due to POLUtils reporting the raw values as 3+damage from item description. map/battleentity.cpp seems to address this +3 already: (

    naturalh2hDMG = (int16)((PTarget->GetSkill(SKILL_HAND_TO_HAND) * 0.11f) + 3);
    ). As such, I have adjusted the values to the +DMG value from the item description.

  2. Most/All ilvl119 h2h weapons were rebalanced in 2017, and the db has had the adjusted values published yet: http://forum.square-enix.com/ffxi/threads/52969-August.-3-2017-%28JST%29-Version-Update

Finally, thanks to a POL Utils data dump from Julian in Discord, I have put together this PR to correct items 1 and 2.

@TeoTwawki TeoTwawki merged commit 9f36520 into DarkstarProject:master Apr 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@neuromancerxi neuromancerxi deleted the neuromancerxi:MrHands branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.