Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework WS Damage Calculations #5861

Merged
merged 2 commits into from May 19, 2019

Conversation

@ibm2431
Copy link
Contributor

commented Apr 17, 2019

Since I needed something to do while waiting for #5824 to be merged, I started a different project, and ended up in weaponskills.lua. One thing lead to another and I ended up reworking the functions used to calculate WS damage, with some fixes along the way:

One thing that I'm not certain on is when Souleater should be applied during the calculations:

Is the damage added on for every hit of the WS, meaning it gets WSC and fTP?
Is it just a static value added on at the very end?
Should it stack with WS DMG+?

I looked for definitive answers, but all the internet was returning were, "Souleater increases weaponskill damage" and people a decade in the past complaining how much DRK sucks because it takes damage to deal damage. So I just left it where was, before WS DMG+ is applied.

@teschnei

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

I'd guess Souleater is after WS DMG+ is applied, but I don't think there's enough of that stat anyways for it to matter that much.

Anyways, regarding the alpha change, there's a few things that I find odd. bg-wiki lists the merit WS as having 85% modifiers on their stat. If you check the history, you'll find that they used to say 100%. The alpha at 99 is 0.85, which made these equivalent if you think about pre-alpha and post-alpha. However, if alpha is now removed, why are they 85% still? Did alpha really get removed or does everything just have it applied at 0.85 in advance? Or did certain WS get nerfed when alpha was removed (as removing alpha would buff everything)?

@ibm2431

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

My understanding of it is that alpha was removed as part of the June 2014 WS overhaul. But as usual the official version notes aren't entirely helpful as it lists the Merit WS for Post-Adjustment as just "Varies depending on merit points allocated".

I did find the original testing thread over at bgwiki.

On page 2 there's a poster saying:
"Apparently they removed alpha correction from the WSC values this update in addition to changing the attribute modifiers themselves (Motenten traced the source back to a JP dev post stating they were removing the 0.85 alpha mod)."

(I haven't been able to find this JP dev post yet)

But on page 5, Mote himself says:
"Have heard someone mention that alpha still seems to apply to merited weaponskills. Based on the results I'm seeing in Stardiver, that seems quite likely."

There's some talk on later pages about alpha still being applied to the merit WS as an SE oversight or glitch, but on Page 13, Mote muses:
"Remember that the merit weaponskills have always had what the players considered a strange way of describing the WSC mod. They weren't described as going up to 100%, but up to 85%. We treated it as 100% with the standard 0.85 multiplier, but maybe SE really didn't use the alpha multiplier on them to begin with."

I'll do some more digging (I'd like to find this JP dev post that supposedly exists).

@ibm2431

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

Try as I might, I have been unable to find the original JP dev post that was mentioned (although I did find the actual person who said so; it wasn't Mote):

"Two new JP posts today. First one seems to be confirming that merit ws still have the 85% alpha applied to them"

However, BG seems pretty convinced that alpha is gone for everything except Merit WS:

Byrth: "No. It doesn't look like SE is including Alpha in these calculations."

Prothescar: "alpha correction removal is extremely unexpected. that's another 15% boost to WSC."

"With the news that alpha correction is being removed"

Mote: "Known changes are new WSC values and the removal of the alpha multiplier."

Sechs: "They also all got the indirect buff of alpha-removal."

Sechs: "Removed Alpha and done specific adjustments (the full extent of which is still unknown) to almost every WS."

Someone months later unhappy about the removal: "Removing alpha was unnecessary for weapon skills and only added to the experience of everything ending up the way it has"

Byrth in 2015: "(no Alpha anymore)"

Now, in regards to the change history on bgwiki for the merit WS:

Sechs: "The thing about alpha still being present for Merit WS is quite something."

"but that might just be because Requiescat still has alpha pox"

I'm inclined to agree with Mote's theory that Merit WS were never using alpha to begin with. My addition to that is maybe it'd have to do with the way their WSC increased with merits, so SE used a different calculation system for them. I also agree with Mote in that players were assuming that alpha was always applied to them, so the Merit WS "were 100% then apply alpha". But after alpha was removed, either realized the mistaken assumption and lowered it to 85% (no alpha ever, we just assumed), or they lowered it to 85% because 100% mod * still-existing alpha is 85% anyway ("alpha still there for merit WS only, so if you're using our WS equations use 85% for the mod"). But you have the same result regardless how you want to represent it.

tldr conclusion: I am 99% certain that alpha is gone, and that merit WS simply never used it to begin with.

@teschnei

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

so when alpha was removed, did that effectively buff every single WS by 1/0.85? or did they modify the wsc to compensate?

@ibm2431

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

It depends on the WS. Most of them got an outright buff (the start of WS damage creep, according to some players). Others got the alpha-removal buff with some WSC changes (still in favor of increasing damage).

Compare Herculean Slash: 60% VIT to 80% VIT. It benefits from the alpha-removal, and got a WSC buff.

Compare Jishnu's Radiance: 60% DEX to 80% DEX. Like Herculean, it got double-buffed.

Compare Blade: Ten: 30% STR / 30% INT to 30% STR / 30% DEX. Other than the WSC mod change (which is still a buff in-of-itself for NIN), the percentages weren't, but it still sees increased damage from the alpha-removal.

Compare Refulgent Arrow. 60% STR to 60% STR. It did get a fTP increase at 3000, but otherwise unchanged. Still gets the boost all other WS (except Merit) got from removing alpha.

Compare Shark Bite: 50% DEX to 40% DEX / 40% AGI. The DEX was dropped down 10% (which compensates for removing alpha, but is still a 5% net increase), and AGI was added. So a net buff plus extra damage.

So, "everything except merit got a buff, and some got more of a buff than others".

It seems that Fr0zt took care of the mod changes back during #865

ibm2431

@ibm2431 ibm2431 force-pushed the ibm2431:ws-work branch from 7037e8e to 1aefb2d May 9, 2019

@TeoTwawki TeoTwawki merged commit dbaaa77 into DarkstarProject:master May 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.