Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rework WS Damage Calculations #5861
Since I needed something to do while waiting for #5824 to be merged, I started a different project, and ended up in
One thing that I'm not certain on is when Souleater should be applied during the calculations:
Is the damage added on for every hit of the WS, meaning it gets WSC and fTP?
I looked for definitive answers, but all the internet was returning were, "Souleater increases weaponskill damage" and people a decade in the past complaining how much DRK sucks because it takes damage to deal damage. So I just left it where was, before WS DMG+ is applied.
I'd guess Souleater is after WS DMG+ is applied, but I don't think there's enough of that stat anyways for it to matter that much.
Anyways, regarding the alpha change, there's a few things that I find odd. bg-wiki lists the merit WS as having 85% modifiers on their stat. If you check the history, you'll find that they used to say 100%. The alpha at 99 is 0.85, which made these equivalent if you think about pre-alpha and post-alpha. However, if alpha is now removed, why are they 85% still? Did alpha really get removed or does everything just have it applied at 0.85 in advance? Or did certain WS get nerfed when alpha was removed (as removing alpha would buff everything)?
Try as I might, I have been unable to find the original JP dev post that was mentioned (although I did find the actual person who said so; it wasn't Mote):
However, BG seems pretty convinced that alpha is gone for everything except Merit WS:
Now, in regards to the change history on bgwiki for the merit WS:
I'm inclined to agree with Mote's theory that Merit WS were never using alpha to begin with. My addition to that is maybe it'd have to do with the way their WSC increased with merits, so SE used a different calculation system for them. I also agree with Mote in that players were assuming that alpha was always applied to them, so the Merit WS "were 100% then apply alpha". But after alpha was removed, either realized the mistaken assumption and lowered it to 85% (no alpha ever, we just assumed), or they lowered it to 85% because 100% mod * still-existing alpha is 85% anyway ("alpha still there for merit WS only, so if you're using our WS equations use 85% for the mod"). But you have the same result regardless how you want to represent it.
tldr conclusion: I am 99% certain that alpha is gone, and that merit WS simply never used it to begin with.
It depends on the WS. Most of them got an outright buff (the start of WS damage creep, according to some players). Others got the alpha-removal buff with some WSC changes (still in favor of increasing damage).
Compare Herculean Slash: 60% VIT to 80% VIT. It benefits from the alpha-removal, and got a WSC buff.
Compare Jishnu's Radiance: 60% DEX to 80% DEX. Like Herculean, it got double-buffed.
Compare Blade: Ten: 30% STR / 30% INT to 30% STR / 30% DEX. Other than the WSC mod change (which is still a buff in-of-itself for NIN), the percentages weren't, but it still sees increased damage from the alpha-removal.
Compare Refulgent Arrow. 60% STR to 60% STR. It did get a fTP increase at 3000, but otherwise unchanged. Still gets the boost all other WS (except Merit) got from removing alpha.
Compare Shark Bite: 50% DEX to 40% DEX / 40% AGI. The DEX was dropped down 10% (which compensates for removing alpha, but is still a 5% net increase), and AGI was added. So a net buff plus extra damage.
So, "everything except merit got a buff, and some got more of a buff than others".