Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding for constructor with optional arguments #1201

Closed
Simpler1 opened this issue Sep 17, 2018 · 1 comment
Closed

Folding for constructor with optional arguments #1201

Simpler1 opened this issue Sep 17, 2018 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone

Comments

@Simpler1
Copy link

As seen in the following image, I would expect to be able to fold the MyHomePage constructor since it has optional arguments on multiple lines.

2018-09-17 16_23_16-main dart - flutter_assets - visual studio code

In vscode, the following is set:
"editor.foldingStrategy": "auto"

(Excellent extension by the way. :) )

@DanTup DanTup added this to the On Deck milestone Sep 18, 2018
@DanTup DanTup added is enhancement in editor Relates to code editing or language features upstream in dart / flutter Needs changing in Dart or Flutter labels Sep 18, 2018
@DanTup DanTup modified the milestones: On Deck, Backlog Mar 19, 2019
@DanTup DanTup added the in lsp/analysis server Something to be fixed in the Dart analysis server label Jun 1, 2020
@DanTup DanTup removed the upstream in dart / flutter Needs changing in Dart or Flutter label Jan 12, 2021
@DanTup DanTup modified the milestones: Backlog, On Deck Jan 12, 2021
dart-bot pushed a commit to dart-lang/sdk that referenced this issue May 24, 2021
Fixes Dart-Code/Dart-Code#1201.

Change-Id: I2865337861397ae15d2c4515b009fa22c678b5b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member

DanTup commented May 24, 2021

Fixed by dart-lang/sdk@d3082bc. As it's in the language server, it'll show up in a future Dart/Flutter SDK release (not the VS Code extension release).

@DanTup DanTup closed this as completed May 24, 2021
@DanTup DanTup modified the milestones: On Deck, v3.23.0 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants