Add a command to write recommended settings to the users User Settings for Dart

[mit-mit]

Start with the following code:

class CircularButton extends StatelessWidget {
  final Widget text;
  final VoidCallback onPressed;

  const CircularButton({this.text, this.onPressed});

  @override
  Widget build(BuildContext context) {
    return Center(
      child: RaisedButton(
        shape: CircleBorder(side: BorderSide(color: Colors.blue, width: 2)),
        child: text,
        onPressed: onPressed,
      ),
    );
  }
}

Next, place the cursor on RaisedButton
Invoke refactoring (option-enter).
Select 'Wrap with new widget'

=>

The code is oddly formatted; I would expect child: RaisedButton( to be indented two positions in from child: widget(, but it's 8 positions in.

Second, when I attempt to type a widget name, say SizedBox, in the widget placeholder text I get no code completion.

[DanTup]

The code is oddly formatted

This appears to be the same issue as microsoft/vscode#44200. Frustratingly, it seems like this is finally getting a fix (microsoft/vscode#57093) but only for completions - yet the issue seems to affect general text edits. I'll open an issue in VS Code about this.

Second, when I attempt to type a widget name, say SizedBox, in the widget placeholder text I get no code completion.

If you press Ctrl+Space does the completion work correctly (it seems to for me)? The snippet mode (where you can tab between placeholders, etc.) is controlled by VS Code and I'm not sure if we can force completion open automatically (but I'll do a little more digging).

[mit-mit]

If you press Ctrl+Space does the completion work correctly (it seems to for me)?

Yes, when I press that I see a 'loading' message for few seconds, and then the completions.

The weird thing is, if I after doing the refactor move the cursor out of widget, back into widget, delete widget and then start typing, then I get the expected immediate completion behavoir...

[DanTup]

I've opened microsoft/vscode#63129 about the indenting - seems to be an issue with SnippetStrings rather than general edits.

The weird thing is, if I after doing the refactor move the cursor out of widget, back into widget, delete widget and then start typing, then I get the expected immediate completion behavoir...

Yeah, that's because it exits snippet mode (when it's in snippet mode, you'll see a box around the word widget.

I managed to find this:

microsoft/vscode#57153

It seems that you can disable this with a VS Code setting:

"editor.suggest.snippetsPreventQuickSuggestions": false

In my quick testing, this seems to solve the issue. Give it a test and see what you think. If we think it works well, we could add it to the Recommended Settings page (which I'm thinking of - at some point - showing a one-time notification to point people at).

[mit-mit]

Yeah, that works a lot better!

Is it not possible to set settings like this programmatically for .dart files?

[DanTup]

Is it not possible to set settings like this programmatically for .dart files?

It is, though I'm not too keen on the idea of changing VS Code defaults just for Dart, since it means people using VS Code for other languages will have inconsistencies they might not understand (it also feels a bit aggressive for us to change their settings, even if it is just for Dart). That's why I started the recommended settings page - to try and draw attention to what I generally consider bad VS Code defaults, and allow users to read the descriptions and pick which ones they want.

I don't feel strongly though, my opinion would be swayed, but I'd want to be fairly sure users wouldn't object. We'd also need to figure out when to set them (since ideally we'd write them into their settings file so they can see what we've done, but we don't want to put them back in if the user deleted them).