Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart icon in file browser sidebar #1384

Closed
patarapolw opened this issue Jan 9, 2019 · 9 comments
Closed

Dart icon in file browser sidebar #1384

patarapolw opened this issue Jan 9, 2019 · 9 comments
Milestone

Comments

@patarapolw
Copy link

patarapolw commented Jan 9, 2019

Currently, it's not beautiful...

screen shot 2019-01-09 at 09 43 25

I would like to change it to

Do you have a plan of this? Is this a right place for this?

Edit: I managed to find https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme and then, I pressed F1 and disabled folder icons.

@DanTup
Copy link
Member

DanTup commented Jan 9, 2019

I believe that VS Code ships with Seti UI icons. I opened a request to add Dart to them here:

jesseweed/seti-ui#325

I think if they're added there they'd make their way into the VS Code default icon set, though I haven't dug into it myself.

@DanTup DanTup added the upstream in vs code / lsp / dap Needs changing in VS Code, LSP or DAP protocols/libraries label Jan 9, 2019
@DanTup DanTup changed the title Icon in file browser sidebar Dart icon in file browser sidebar Jan 9, 2019
@DanTup DanTup added this to the On Deck milestone Feb 20, 2019
@DanTup DanTup removed this from the On Deck milestone Jul 9, 2019
@DanTup DanTup removed the upstream in vs code / lsp / dap Needs changing in VS Code, LSP or DAP protocols/libraries label Jul 9, 2019
@DanTup DanTup added this to the v3.3.0 milestone Jul 9, 2019
@DanTup
Copy link
Member

DanTup commented Jul 9, 2019

The icons library wasn't being maintained, but someone from MS has gotten access and started merging PRs. The Dart icon has been merged and will be included in the next update (it's already available in Insiders) 🎉

@DanTup DanTup closed this as completed Jul 9, 2019
@DanTup DanTup modified the milestones: v3.3.0, v3.4.0 Jul 18, 2019
@monajafi
Copy link

monajafi commented Aug 8, 2019

If you look at the following video the icon is available in older versions of VSCode or maybe the owner of that video fixed it himself
https://www.youtube.com/watch?v=8F2uemqLwvE&list=PLJbE2Yu2zumDjfrfu8kisK9lQVcpMDDzZ

@DanTup
Copy link
Member

DanTup commented Aug 8, 2019

I believe that video is using a different icon pack to the Seti UI icons that are default in VS Code.

The update that included the icon was reverted in VS Code due to some issues but I don't know what the current status is.. @orta - do you know? were you able to resolve the issues and re-land the updates?

@monajafi
Copy link

monajafi commented Aug 9, 2019

I installed vscode-icons icon theme It's very cool

@orta
Copy link

orta commented Aug 9, 2019

We figured it out and the latest release should be up to date with seti-ui

@monajafi
Copy link

monajafi commented Aug 9, 2019

@orta great job, the vscode-icons besides dart icon has a lot of cool icons for many languages and folders etc

@orta
Copy link

orta commented Aug 9, 2019

Great!

@DanTup
Copy link
Member

DanTup commented Aug 19, 2019

@orta Yep, I see the new Dart icon in latest stable - thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants