Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Capture Logs" notification shouldn't "vanish" while logs are being captured #1416

Closed
DanTup opened this issue Jan 23, 2019 · 3 comments
Closed

"Capture Logs" notification shouldn't "vanish" while logs are being captured #1416

DanTup opened this issue Jan 23, 2019 · 3 comments
Labels
is enhancement
Milestone
v3.4.0

Comments

@DanTup
Copy link
Member

DanTup commented Jan 23, 2019

This will stop it vanishing after 10 seconds while logs are still being captured.

microsoft/vscode#49044
@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels Jan 23, 2019
@DanTup DanTup added this to the v2.23.0 milestone Jan 23, 2019
@DanTup DanTup removed the in editor Relates to code editing or language features label Jan 23, 2019
@DanTup
Copy link
Member Author

DanTup commented Jan 29, 2019

Can't do this, VS Code doesn't let us have buttons on the progress notification.

@DanTup DanTup closed this as completed Jan 29, 2019
@DanTup DanTup removed this from the v2.23.0 milestone Jan 29, 2019
@DanTup
Copy link
Member Author

DanTup commented Feb 28, 2019

We can make it warning?

@DanTup DanTup reopened this Feb 28, 2019
@DanTup DanTup added this to the v2.25.0 milestone Feb 28, 2019
@DanTup DanTup changed the title Change "Capture Logs" notification to a progress notification Change "Capture Logs" notification to a warning so it doesn't "vanish" during capture Feb 28, 2019
@DanTup
Copy link
Member Author

DanTup commented Feb 28, 2019

Warnings disappear too! Blocked on microsoft/vscode#65459

@DanTup DanTup modified the milestones: v2.25.0, Backlog Feb 28, 2019
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 28, 2019
@DanTup DanTup changed the title Change "Capture Logs" notification to a warning so it doesn't "vanish" during capture "Capture Logs" notification shouldn't "vanish" while logs are being captured Feb 28, 2019
@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Aug 26, 2019
@DanTup DanTup modified the milestones: Backlog, v3.4.0 Aug 26, 2019
@DanTup DanTup closed this as completed in 9f39ea7 Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is enhancement
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@DanTup