Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fs access async, or reduce the number of calls in a single sync function #1442

Closed
DanTup opened this issue Feb 1, 2019 · 0 comments
Closed
Labels
in editor Relates to code editing or language features is performance
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 1, 2019

Related to #1441. Even though we'll now call this less, the slow fs access and the number of calls in one function call may still result in warnings about the extension host. Making them async may be best.

@DanTup DanTup added in editor Relates to code editing or language features is performance labels Feb 1, 2019
@DanTup DanTup modified the milestones: v2.23.0, On Deck Feb 1, 2019
@DanTup DanTup modified the milestones: On Deck, v3.7.0 Oct 24, 2019
@DanTup DanTup closed this as completed in bf91e92 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is performance
Projects
None yet
Development

No branches or pull requests

1 participant