Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a test that outputs Observatory banner in non-debug mode connects to that URL #1449

Closed
DanTup opened this issue Feb 6, 2019 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 6, 2019

While running devtools tests (integration/logging) with the Run CodeLens link it was terminating early. Turned out that because we didn't get our own Observatory banner (since we ran without debugger) we were picking up the output from the tests (which spawn a process):

[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":4,"result":"success","skipped":false,"hidden":true,"type":"testDone","time":15431}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"group":{"id":5,"suiteID":0,"parentID":3,"name":"integration logging","metadata":{"skip":false,"skipReason":null},"testCount":2,"line":32,"column":5,"url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/integration_test.dart"},"type":"group","time":15432}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"test":{"id":6,"name":"integration logging displays log data","suiteID":0,"groupIDs":[2,3,5],"metadata":{"skip":false,"skipReason":null},"line":24,"column":3,"url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/logging.dart","root_line":32,"root_column":5,"root_url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/integration_test.dart"},"type":"testStart","time":15433}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"PID = 16331","type":"print","time":15444}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"16331: Got line: Observatory listening on http://127.0.0.1:52442/","type":"print","time":15521}
[10:20:11 GMT+0000 (GMT)] [Observatory] [Info] Observatory connection closed: 1006 ()
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"16331: Got line: starting logging app","type":"print","time":15783}
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] Disconnect requested!
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Going to terminate with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Terminating related process 16285 with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Terminating main process with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Removing all stored data...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Waiting for process to finish...

We should be a bit more picky about what output we can read this from - we shouldn't be reading it from Pub Test JSON like this.

@DanTup DanTup added this to the On Deck milestone Feb 6, 2019
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Feb 6, 2019
@DanTup DanTup modified the milestones: On Deck, v2.25.0 Feb 20, 2019
@DanTup DanTup closed this as completed in cc56413 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Development

No branches or pull requests

1 participant