Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trigger characters that often have whitespace after them #1494

Closed
DanTup opened this issue Feb 28, 2019 · 0 comments
Closed

Remove trigger characters that often have whitespace after them #1494

DanTup opened this issue Feb 28, 2019 · 0 comments
Labels
in editor Relates to code editing or language features is bug fix is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 28, 2019

There have been many issues relating to trigger characters: #1483, #1406, #1351, #1256, #1254. Most of these stem from us trying to open the completion every time we think it'd be useful for users, however other extensions don't seem to do this and VS Code doesn't support it well in cases where whitespace may appear after a trigger character (microsoft/vscode#66860, microsoft/vscode#69542).

The only good fix I can think of is to remove trigger characters that might come before whitespace (and undo the filterText change).

Current trigger characters and proposed changes:

  • . - used when accessing members - KEEP
  • : - used for named arguments - may be followed by whitespace - REMOVE
  • = - used for assignments/named arg defaults - may be followed by whitespace - REMOVE
  • ( - used for calling members, not usually followed by whitespace - KEEP?
  • $ - used in variable interpolation - not followed by whitespace - KEEP
  • { - used in variable interpolation - may be followed by newlines (blocks) but this is filtered to ${ in the completion handler - KEEP
  • ' - filtered to only imports/exports in completion handler - KEEP
  • " - filtered to only imports/exports in completion handler - KEEP
  • / - filtered to only imports/exports in completion handler - KEEP
  • \ - filtered to only imports/exports in completion handler - KEEP
@DanTup DanTup added this to the v2.25.0 milestone Feb 28, 2019
@DanTup DanTup added is enhancement is bug fix in editor Relates to code editing or language features labels Feb 28, 2019
@DanTup DanTup closed this as completed in a315287 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug fix is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant