Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Logs command doesn't capturing Observatory logs intermittently #1545

Closed
DanTup opened this issue Mar 20, 2019 · 0 comments
Closed

Capture Logs command doesn't capturing Observatory logs intermittently #1545

DanTup opened this issue Mar 20, 2019 · 0 comments
Labels
in commands Relates to commands (usually invoked from the command Palette) in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Mar 20, 2019

Noticed that periodically, Observatory logs were not being logged to the Capture Logs command output. Turns out we were comparing Sessions by objects, and sometimes these would be different. In that case, the ID was always the same (and we should've probably used this in the first place).

Most likely this is an async race, maybe related to the same issue in the last VS Code release:

https://github.com/Microsoft/vscode/blob/ac46ca2a5e5aaab3f01cffec46d3e2ac96519f1f/src/vs/workbench/api/node/extHostDebugService.ts#L798

@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Mar 20, 2019
@DanTup DanTup added this to the v2.25.0 milestone Mar 20, 2019
@DanTup DanTup added the in commands Relates to commands (usually invoked from the command Palette) label Mar 20, 2019
@DanTup DanTup changed the title Capture Logs command isn't capturing Observatory logs Debug sessions are intermittently not found Mar 20, 2019
@DanTup DanTup changed the title Debug sessions are intermittently not found Capture Logs command doesn't capturing Observatory logs intermittently Mar 20, 2019
@DanTup DanTup closed this as completed in 9fa66da Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Development

No branches or pull requests

1 participant