Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to auto-launch DevTools when starting a debug session #1557

Closed
DanTup opened this issue Mar 25, 2019 · 3 comments · Fixed by #1982
Closed

Add an option to auto-launch DevTools when starting a debug session #1557

DanTup opened this issue Mar 25, 2019 · 3 comments · Fixed by #1982
Assignees
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Mar 25, 2019

Probably we should allow the user to specify which types to do this for (Dart, webdev daemon, Flutter).

@jacob314 I think this requires the ability to launch the DevTools from the DevTools server (so it can track the process it spawned). Do you know if there are issues open to track that?

@DanTup DanTup added this to the v2.26.0 milestone Mar 25, 2019
@DanTup DanTup added is enhancement blocked on dart / flutter Requires a change in Dart or Flutter to progress in commands Relates to commands (usually invoked from the command Palette) labels Mar 25, 2019
@jacob314
Copy link

Added a devtools issue to track the server piece of this.
flutter/devtools#463

I would only suggest launching automatically for flutter_web and flutter.

@DanTup DanTup changed the title Add an option to auto-launch DevTools when starting a debug session VS Code: Add an option to auto-launch DevTools when starting a debug session Mar 25, 2019
@csells csells changed the title VS Code: Add an option to auto-launch DevTools when starting a debug session P1.5: VS Code: Add an option to auto-launch DevTools when starting a debug session Apr 1, 2019
@DanTup DanTup added the important Something important! label Apr 10, 2019
@DanTup DanTup removed the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Apr 25, 2019
@DanTup DanTup modified the milestones: v2.26.0, v2.26.1 Apr 25, 2019
@DanTup
Copy link
Member Author

DanTup commented Apr 29, 2019

I don't think this works very well right now, as every time you stop/start a session, you get a new browser tab. Maybe we should try a querystring param in DevTools to have it close its tab when the VM connection drops (assuming we can), and then we could pass that in the case where the tools are being auto-launched at the start of each session?

@csells @jacob314 WDYT?

@DanTup
Copy link
Member Author

DanTup commented Apr 30, 2019

@jacob314 I've opened flutter/devtools#612

I wonder if we should also have an option for when we call launchDevTools to say "if it's already open, just bring the browser+tab to the front"? (I don't think it'll work for the ChromeOS native-browser case, but maybe for those we own the processes for?).

FWIW, unless anyone shouts, I'm going to move this to a future release. I think it's non-critical and I want to stop making changes for vNext ASAP (ideally today).

@DanTup DanTup modified the milestones: v2.26.1, v2.27.0 Apr 30, 2019
@DanTup DanTup removed the important Something important! label May 20, 2019
@DanTup DanTup modified the milestones: v3.1.0, On Deck May 20, 2019
@DanTup DanTup changed the title P1.5: VS Code: Add an option to auto-launch DevTools when starting a debug session Add an option to auto-launch DevTools when starting a debug session Sep 9, 2019
@DanTup DanTup modified the milestones: On Deck, v3.5.0 Sep 9, 2019
@DanTup DanTup modified the milestones: v3.5.0, On Deck Sep 17, 2019
@DanTup DanTup modified the milestones: On Deck, v3.6.0 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants