Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing files outside of "lib" inside Dependencies tree #1590

Closed
Rodsevich opened this issue Apr 4, 2019 · 3 comments
Closed

Allow accessing files outside of "lib" inside Dependencies tree #1590

Rodsevich opened this issue Apr 4, 2019 · 3 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@Rodsevich
Copy link

Ideally, through rightclicking from Dependencies view

@DanTup DanTup added this to the On Deck milestone Apr 8, 2019
@DanTup DanTup added in editor Relates to code editing or language features is enhancement labels Apr 8, 2019
@DanTup DanTup modified the milestones: On Deck, v2.26.0 Apr 16, 2019
@DanTup
Copy link
Member

DanTup commented Apr 16, 2019

I implemented this:

Screenshot 2019-04-16 at 2 03 51 pm

However I found a problem:

Screenshot 2019-04-16 at 2 04 01 pm

If you open it as its own folder (either in a new window, or even as an additional analysis root in for the current window) it doesn't resolve its own dependencies, and therefore everything has squiggles:

Screenshot 2019-04-16 at 2 04 01 pm

(it also tries to prompt you to run pub get, though I could fix that).

I think this is because without a .packages file, it doesn't know where to get these packages from (whereas inside your own project, the .packages file has all transient dependencies).

So maybe the only way to handle this would be to do your original suggestion, which is to allow the tree to render from the root of the package instead of its lib folder. Or, we could add the folder to the VS Code workspace and exclude it as an analysis root.

I'll come back to it after doing #1591 to see if anything better comes to me.

@Rodsevich
Copy link
Author

Nice! 😄

allow the tree to render from the root of the package instead of its lib folder. Or, we could add the folder to the VS Code workspace and exclude it as an analysis root.

Any option would be useful for me, but I think that it would be nice to have both options for the plugin in order to extend the usefulness for the most users possible

@DanTup DanTup modified the milestones: v2.26.0, On Deck Apr 22, 2019
@DanTup DanTup modified the milestones: On Deck, v3.16.0 Oct 1, 2020
@DanTup DanTup modified the milestones: v3.16.0, v3.17.0 Oct 21, 2020
@DanTup DanTup changed the title Add an option to open a dependency package Allw accessing files outside of "lib" inside Dependencies tree Nov 18, 2020
@DanTup DanTup changed the title Allw accessing files outside of "lib" inside Dependencies tree Allow accessing files outside of "lib" inside Dependencies tree Nov 18, 2020
@DanTup
Copy link
Member

DanTup commented Nov 18, 2020

The tree now starts one level up from where the package resolves, if the resolved folder is called "lib":

Screenshot 2020-11-18 at 16 04 03

@DanTup DanTup closed this as completed in 3af8d40 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants