Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdio.dart is not coloured correctly #1635

Closed
DanTup opened this issue Apr 22, 2019 · 1 comment
Closed

stdio.dart is not coloured correctly #1635

DanTup opened this issue Apr 22, 2019 · 1 comment
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Apr 22, 2019

Screenshot 2019-04-22 at 11 55 34 am

@DanTup DanTup added is bug in editor Relates to code editing or language features labels Apr 22, 2019
@DanTup DanTup added this to the v2.26.0 milestone Apr 22, 2019
@DanTup
Copy link
Member Author

DanTup commented Apr 24, 2019

This is caused by the indenting of /** multi-line */ blocks, it was matching the 4-space-indent and being considered code. This included the last line */ so it didn't "exit" the comment properly.

For testing, I duplicated everything in the comments file and put it inside a class so it was indented enough. After the fix, the only change was the bit we wanted:

Screenshot 2019-04-24 at 11 17 47 am

@devoncarew FYI. It's possible I introduced this with one of the earlier changes, so if you don't have them you might not need this. Best way is to type stdio and then Go-to-Def on it, and see whether most of the file is green/comment.

I've scanned through a few of the large Flutter files and made sure there are no other obvious instances of anything like this, nor any files that are comments till the end.

DanTup added a commit that referenced this issue Apr 24, 2019
@DanTup DanTup closed this as completed in 08bf648 Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

1 participant