Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch icons to being a sub-module and shipped inside the extension to allow working offline/no delay #1709

Closed
DanTup opened this issue May 15, 2019 · 0 comments
Labels
in editor Relates to code editing or language features is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented May 15, 2019

The fix for #1707 was just to change the URL to point at our own copy of icons (generated by IntelliJ's script that renders them in the simulator). Pulling them from the web means there's a delay (and you need to be online) so now we have them all in a convenient repo, we should just ship them in the extension (by adding the repo as a submodule).

@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels May 15, 2019
@DanTup DanTup added this to the On Deck milestone May 15, 2019
@DanTup DanTup modified the milestones: On Deck, v3.6.0 Oct 8, 2019
@DanTup DanTup modified the milestones: v3.6.0, v3.7.0 Oct 21, 2019
DanTup added a commit that referenced this issue Nov 20, 2019
DanTup added a commit that referenced this issue Nov 20, 2019
@DanTup DanTup closed this as completed in 7b0f030 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant