Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart.env isn't applying unless config is reloaded #1725

Closed
DanTup opened this issue May 20, 2019 · 3 comments
Closed

dart.env isn't applying unless config is reloaded #1725

DanTup opened this issue May 20, 2019 · 3 comments
Labels
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented May 20, 2019

Think I broke this in b2a8796 because setupToolEnv is no longer called automatically (FYI @stuartmorgan - I think you may have mentioned this to me, but somehow I lost the report, and just re-discovered it today!).

@DanTup DanTup added the is bug label May 20, 2019
@DanTup DanTup added this to the v3.1.0 milestone May 20, 2019
@DanTup DanTup changed the title dart.env isn't applying properly dart.env isn't applying unless config is reloaded May 20, 2019
@stuartmorgan
Copy link
Contributor

stuartmorgan commented May 20, 2019

I'm actually seeing it not work at all on a second machine, and I got a report of the same thing from someone else recently.

I was going to follow up and see if maybe the reason I was seeing inconsistent behavior (which is why I hadn't filed the issue original; when I retested at the time it worked on three machines I tried and only failed on one) was due to versions, and the working machines weren't quite as up-to-date.

Recently the only way I can seem to make the flow work is to command-line launch VS Code from a terminal that sets the environment variable.

@DanTup DanTup closed this as completed in f34a2af May 20, 2019
@DanTup
Copy link
Member Author

DanTup commented May 20, 2019

The bug I introduced basically means it'll only work if your trigger a config reload (which usually means changing your config, either directly, or by using something like the SDK switching).

I've pushed a fix - if it's annoying that it's broken, lmk and I'll send you build with it in (or if you have vsce installed you can run vsce package to build your own).

@stuartmorgan
Copy link
Contributor

Oh, I see what you mean by 'reloaded' now. I was thinking 'relaunched', but this would actually be the opposite.

That definitely explains why I couldn't repro it when I specifically went and set it up on a new machine to see if it was really broken :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants