Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter UI Guides preview feedback #1731

Closed
DanTup opened this issue May 21, 2019 · 14 comments
Closed

Flutter UI Guides preview feedback #1731

DanTup opened this issue May 21, 2019 · 14 comments

Comments

@DanTup
Copy link
Member

@DanTup DanTup commented May 21, 2019

For info on the Flutter UI Guides preview, see the v3.31 release notes. This thread is for collecting feedback on the guides (including the customTracking setting).

@DanTup DanTup added this to the On Deck milestone May 21, 2019
@digitalhurricane-io
Copy link

@digitalhurricane-io digitalhurricane-io commented Jun 1, 2019

I have both dart.previewFlutterUiGuides and dart.previewFlutterUiGuidesCustomTracking enabled.

I've restarted vscode.

When I write new code, the guidelines appear.

But they don't appear on code that I've already written.

Edit: Seems to not appear only on some code I've already written.

Is that expected behavior?

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Jun 1, 2019

@digitalhurricane-io it's not expected behaviour :( Do you have any syntax errors in the file/code that isn't working? Would you mind opening a new issue specifically for this, and include screenshots of the code that's not working? Thanks!

Loading

@digitalhurricane-io
Copy link

@digitalhurricane-io digitalhurricane-io commented Jun 1, 2019

I'm nesting widgets inside a ternary operator on the offending code. Perhaps this is why?

Edit: I've opened an issue with a screenshot of the code here #1771

Loading

@windwp
Copy link

@windwp windwp commented Jun 3, 2019

UI guides do not work inside the builder.

Loading

@marcoms
Copy link

@marcoms marcoms commented Jun 11, 2019

Guide formatting breaks when using tabs for indentation

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Jun 12, 2019

@marcoms good catch - I opened #1791 specifically for that and will fix for vNext.

Loading

@jckpn
Copy link

@jckpn jckpn commented Jun 28, 2019

Only works in some files for me... not sure why or what I'm doing wrong.

Here it works great:
image

Here it doesn't seem to work (at least not how I would expect):

image

(Both are files I wrote before enabling the UI guides)

This is such a great idea in theory though, will make writing code in Flutter so much nicer.

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Jul 8, 2019

@jckpn the second screenshot uses builders, which didn't support these. I believe that's been improved in a later SDK, but hasn't made the Flutter stable channel yet. Hopefully it'll just start working when it does :-)

Loading

@a-eid
Copy link

@a-eid a-eid commented Dec 25, 2019

not sure why it looks like that for me..

Screen Shot 2019-12-25 at 13 56 09

Loading

@a-eid
Copy link

@a-eid a-eid commented Dec 25, 2019

could be the custom line height I think..

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Jan 2, 2020

@a-eid what is your line-height set to? Custom line heights will cause gaps (see #1902) but it shouldn't have such large spaces unless you've set your line height really high.

Loading

@emme1444
Copy link

@emme1444 emme1444 commented Feb 8, 2020

Italic multiline comments causes the guidelines within the comment to also tilt.
See screenshot:
Screenshot 2020-02-08 at 15 59 42

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Feb 13, 2020

@emme1444 looks like that's been filed at #2239 - thanks!

Loading

@DanTup
Copy link
Member Author

@DanTup DanTup commented Oct 27, 2020

Thanks for all the feedback. I don't think there's much more to collect from this issue so I'll close it. The UI guides feature remains behind a preview flag because it's method of rendering is not too reliable but there are currently no other available APIs.

If VS Code gets a better API for this in the future (microsoft/vscode#73780), we can move them over and hopefully have something good enough to ship on-by-default.

Loading

@DanTup DanTup closed this Oct 27, 2020
@DanTup DanTup removed this from the On Deck milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants