New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of completions #1750
Comments
Some (terrible) figures from the committed test on initial code:
Memory does go back down, so we're probably not leaking, just allocating a lot for every big completion request. |
Without the new completions, numbers are tiny, confirming it's that work that's causing the issues:
|
It seems that a lot of this time may be within VS Code for passing the data between the extension host and UI (if we do all the computation but just don't return the results, it goes super fast). I've opened microsoft/vscode#74418 to see if it's possible this could be improved there or not. |
Going to close this since a lot of work was done in this version. There's still a branch that has some cleanup that might improve things further, but that's for a future milestone. |
As well as probably being the cause of #1721, the performance of completions with unimported symbols is generally poor.Testing on Windows PC with the following test (inside
test\flutter_only\providers\completion_item_provider.test.ts
):Output from a few runs:
The text was updated successfully, but these errors were encountered: