Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion lists items multiple times, even for the same file #1786

Closed
DanTup opened this issue Jun 10, 2019 · 1 comment
Closed

Completion lists items multiple times, even for the same file #1786

DanTup opened this issue Jun 10, 2019 · 1 comment
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jun 10, 2019

Screenshot 2019-06-10 at 4 16 35 pm

Here, the imports are duplicated - not just because they're imported from different files - the same auto-import file is listed multiple times.

real_def.dart contains the class, and both proxy1.dart and proxy2.dart re-export it. The completion lists proxy1.dart and proxy2.dart auto-imports twice each.

@DanTup DanTup added is bug in editor Relates to code editing or language features labels Jun 10, 2019
@DanTup DanTup added this to the v3.2.0 milestone Jun 10, 2019
@DanTup
Copy link
Member Author

DanTup commented Jun 10, 2019

This is because we loop through the server response and assume no dupes, but that's not correct (see dart-lang/sdk#37211). Will revisit this when it's clear whether clients should do this or the server will fix it.

@DanTup DanTup closed this as completed in befa184 Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

1 participant