Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a faster way to find project folders in the tree #1840

Closed
DanTup opened this issue Jul 8, 2019 · 2 comments
Closed

Find a faster way to find project folders in the tree #1840

DanTup opened this issue Jul 8, 2019 · 2 comments
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jul 8, 2019

Enumerating all the folders seems like it can be slow:

#1819 (comment)

Maybe there's a better way we can do this (eg. get a list of all pubspec.yamls from the FS within the top 3 levels without having to hit the FS so much).

@DanTup DanTup added this to the v3.3.0 milestone Jul 8, 2019
DanTup added a commit that referenced this issue Jul 9, 2019
@DanTup
Copy link
Member Author

DanTup commented Jul 9, 2019

Tried a few things, but generally they were much worse (on my MacBook Pro at least):

#1819 (comment)

(Though the original code only took 100ms here for 1000 projects, which is nothing like the 100ms-per-exists-check seen in the original profile).

@DanTup DanTup modified the milestones: v3.3.0, v3.4.0 Jul 10, 2019
DanTup added a commit that referenced this issue Jul 10, 2019
@DanTup DanTup modified the milestones: v3.4.0, v3.5.0 Aug 28, 2019
@DanTup
Copy link
Member Author

DanTup commented Sep 19, 2019

Fixed by #2003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant