Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The colors of text in the debug console window are contradict with each other #1845

Closed
zhengger opened this issue Jul 9, 2019 · 4 comments
Closed
Labels
awaiting info Requires more information from the customer to progress in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone

Comments

@zhengger
Copy link

zhengger commented Jul 9, 2019

For example in the screenshot attached below, the "Element.updateChild. " part in the line "I/flutter ( 4435): #2 Element.updateChild. package:flutter/…/widgets/framework.dart:286" is invisible due to its white color which is contradict with the words in the front which is black.
Can you fix it or give me some suggestion. Thanks!

image

@DanTup DanTup added this to the v3.3.0 milestone Jul 10, 2019
@DanTup DanTup added in debugger Relates to the debug adapter or process of launching a debug session is bug labels Jul 10, 2019
@DanTup
Copy link
Member

DanTup commented Jul 10, 2019

Which VS Code colour theme are you using? With the default VS Code themes the colours are automatically adjusted so they work on both light and dark. The Solarized theme doesn't seem to do this, but it also doesn't look like yours.

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Jul 10, 2019
@zhengger
Copy link
Author

Hi Dan,
Thank you so much.
I'm using Github Light Theme.
Besides this theme I also tried other light themes but the problem remained.
Well, I just found a workaround...Just set "terminal.ansiWhite": "#450af7", and then the invisible text appeared in "#450af7" color.

image

@DanTup
Copy link
Member

DanTup commented Jul 11, 2019

Looking at the built-in defaults, it seems like it's expected that light themes will set ansiWhite to something dark:

https://github.com/microsoft/vscode/blob/4330dd0eb41c2a2b5773ce2f05d1160f0b39bc76/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts#L97

	'terminal.ansiWhite': {
		index: 7,
		defaults: {
			light: '#555555',
			dark: '#e5e5e5',
			hc: '#e5e5e5'
		}
	},

But weirdly, the same is not done for black:

	'terminal.ansiBlack': {
		index: 0,
		defaults: {
			light: '#000000',
			dark: '#000000',
			hc: '#000000'
		}
	},

So it's not clear how this is expected to work! I'll see if I can come up with something that behaves better in both (like a grey).

@DanTup DanTup closed this as completed in c0ef559 Jul 11, 2019
@DanTup
Copy link
Member

DanTup commented Jul 11, 2019

Thanks - I've changed to using 256 bit colours and selected a medium grey which seems to work ok on all themes I tried (including the ones you linked). FWIW, the frames being greyed are framework frames, so hopefully the ones you're less interested in (it was done so your own code stands out in the stack trace). There are some upcoming changes to how errors are shown though, so this may change further in an upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting info Requires more information from the customer to progress in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Development

No branches or pull requests

2 participants