Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move debug adapters to run out of process #1876

Closed
1 task done
DanTup opened this issue Jul 18, 2019 · 0 comments
Closed
1 task done

Move debug adapters to run out of process #1876

DanTup opened this issue Jul 18, 2019 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jul 18, 2019

We can now return a DebugAdapterExecutable from provideDebugAdapter that will allow us to run out debug adapters out-of-process again, but still pick a different one based on project type:

https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_28.md#debug-api-1
microsoft/vscode#59107

This will remove any possibility of us leaking memory in debug sessions that could affect the extension host and prevent us accidentally sharing state between the two (which we currently do, like with globalFlutterArgs).

  • re-enable the lint in lints/disallowImportingNonSharedCodeRule.js when DAs run out-of-process
@DanTup DanTup added is non-functional in debugger Relates to the debug adapter or process of launching a debug session labels Jul 18, 2019
@DanTup DanTup added this to the v3.4.0 milestone Jul 18, 2019
@DanTup DanTup modified the milestones: v3.4.0, v3.5.0 Aug 26, 2019
@DanTup DanTup modified the milestones: v3.5.0, v3.6.0 Oct 1, 2019
@DanTup DanTup modified the milestones: v3.6.0, v3.7.0 Oct 17, 2019
@DanTup DanTup modified the milestones: v3.7.0, v3.8.0 Nov 19, 2019
@DanTup DanTup modified the milestones: v3.8.0, v3.9.0 Jan 2, 2020
DanTup added a commit that referenced this issue Feb 3, 2020
@DanTup DanTup modified the milestones: v3.9.0, On Deck Mar 11, 2020
@DanTup DanTup modified the milestones: On Deck, v3.14.0 Aug 7, 2020
DanTup added a commit that referenced this issue Aug 7, 2020
DanTup added a commit that referenced this issue Aug 10, 2020
DanTup added a commit that referenced this issue Aug 10, 2020
@DanTup DanTup closed this as completed in 0b65a03 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant