Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Restart doesn't resume debugger state #1994

Closed
DanTup opened this issue Sep 16, 2019 · 5 comments
Closed

Hot Restart doesn't resume debugger state #1994

DanTup opened this issue Sep 16, 2019 · 5 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 16, 2019

See flutter/flutter#13396 (comment)

When we handle Hot Restart, we never tell VS Code we've continued, so it gets stuck in a pause state.

@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Sep 16, 2019
@DanTup DanTup added this to the v3.5.0 milestone Sep 16, 2019
@DanTup DanTup closed this as completed in 2a2027d Sep 16, 2019
@DanTup
Copy link
Member Author

DanTup commented Sep 16, 2019

@escamoteur @nickmeinhold

Alpha build here if you want to try it out to ensure it solves all your issues:

https://github.com/Dart-Code/Dart-Code/releases/tag/v3.5.0-alpha.3

@DanTup DanTup added the in flutter Relates to running Flutter apps label Sep 16, 2019
@escamoteur
Copy link

escamoteur commented Sep 16, 2019 via email

@maks
Copy link

maks commented Sep 16, 2019

@DanTup and @escamoteur thanks for following up on this!
Sorry I didnt follow up my original comment on 13396. I'm pretty sure this is the issue I was seeing, I'm trying out the alpha.3 build now.

@szotp
Copy link
Contributor

szotp commented Apr 9, 2020

Issue persists if the breakpoint was to be reached multiple times, here is minimal sample:

import 'package:flutter/material.dart';

void main() {
  foo();
  foo();
  runApp(SizedBox());
}

void foo() {
  // put breakpoint here
  print('foo');
}

Tested on stable

[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.2 19C57, locale en-GB)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
[!] Android Studio (version 3.6)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.44.0)
[✓] Connected device (1 available)

And master

[✓] Flutter (Channel master, v1.18.0-5.0.pre.46, on Mac OS X 10.15.2 19C57, locale en-GB)

Should I create ticket here or in flutter repo?

@DanTup
Copy link
Member Author

DanTup commented Apr 9, 2020

@szotp please create an issue here, including exact details of the actions you're performing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Projects
None yet
Development

No branches or pull requests

4 participants