Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzeAngularTemplates doesn't add HTML_MODE to providers #2007

Closed
DanTup opened this issue Sep 19, 2019 · 1 comment
Closed

analyzeAngularTemplates doesn't add HTML_MODE to providers #2007

DanTup opened this issue Sep 19, 2019 · 1 comment
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 19, 2019

See #1981 (comment).

@DanTup DanTup added is bug in editor Relates to code editing or language features labels Sep 19, 2019
@DanTup DanTup added this to the v3.5.0 milestone Sep 19, 2019
@DanTup
Copy link
Member Author

DanTup commented Sep 19, 2019

Reading supportsAnalyzingHtmlFiles will involve delaying creation of all providers until the analysis server is set up and provides a version, which seems a bit risky. As such, since it's supported since a very old Dart SDK (1.18), I'm going to just remove the check. I haven't seen any 1.28 SDKs in stats in a very long time.

@DanTup DanTup closed this as completed in 7e44153 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

1 participant